Skip to content

Resolve "Improve Node Typing"

Julius Balzer requested to merge 258-improve-node-typing into development

Summary

Introduce generics for the node typing. We have a generic type N = TypeVar("N", bound=Node) that we can use for typing instead of Node directly. So instead of using type Nodes for some Connection[<node-type>], we can now use Nodes[<node-type>]

For the live connection we still use Node for <node-type>, since we want to be able to have mixed nodes. For other conncetions <node-type> will be the matching node type

Explain your context

The typing in the connectors does not work properly, since they expect nodes with their protocol. But typing implies AnyNode.

Please list breaking changes, new features or bugfixes

  • Breaking changes:

    • Updated Node typing:
      • Introduced generics in place of AnyNode.
      • Nodes has to be used with Node Type, e.g. Nodes[NodeModbus]
  • New features:

  • Bugfixes:

Closes #258 (closed)

Edited by Julius Balzer

Merge request reports